[Zodb-checkins] CVS: ZODB3/ZEO - ClientStorage.py:1.118

Jeremy Hylton jeremy at zope.com
Fri Jan 2 13:43:11 EST 2004


Update of /cvs-repository/ZODB3/ZEO
In directory cvs.zope.org:/tmp/cvs-serv9689/ZEO

Modified Files:
	ClientStorage.py 
Log Message:
Add comment about apparent thread safety of this code.


=== ZODB3/ZEO/ClientStorage.py 1.117 => 1.118 ===
--- ZODB3/ZEO/ClientStorage.py:1.117	Fri Jan  2 10:51:00 2004
+++ ZODB3/ZEO/ClientStorage.py	Fri Jan  2 13:43:10 2004
@@ -955,8 +955,11 @@
                 raise ClientDisconnected(
                        'Calling tpc_finish() on a disconnected transaction')
 
+            # The calls to tpc_finish() and _update_cache() should
+            # never run currently with another thread, because the
+            # tpc_cond condition variable prevents more than one
+            # thread from calling tpc_finish() at a time.
             tid = self._server.tpc_finish(id(txn))
-
             self._lock.acquire()  # for atomic processing of invalidations
             try:
                 self._update_cache(tid)




More information about the Zodb-checkins mailing list