[Zodb-checkins] SVN: ZODB/trunk/ Mrege rev 30658 from 3.4 branch.

Tim Peters tim.one at comcast.net
Mon Jun 6 12:36:27 EDT 2005


Log message for revision 30659:
  Mrege rev 30658 from 3.4 branch.
  
  checkCrossDBInvalidations:  make this willing to wait longer in all,
  and increase the sleep time per failing loop iteration.  The hope is
  this will allow the test to pass on slower and/or "too busy" machines.
  I can't test that, though, since I couldn't get the test to fail at
  all on a Windows or a Linux box.
  

Changed:
  U   ZODB/trunk/NEWS.txt
  U   ZODB/trunk/src/ZEO/tests/ConnectionTests.py

-=-
Modified: ZODB/trunk/NEWS.txt
===================================================================
--- ZODB/trunk/NEWS.txt	2005-06-06 16:32:13 UTC (rev 30658)
+++ ZODB/trunk/NEWS.txt	2005-06-06 16:36:26 UTC (rev 30659)
@@ -45,7 +45,14 @@
   error (for example, a corrupt database can cause this), the message it
   produces no longer contains unprintable characters.
 
+Tests
+-----
 
+- (3.4c2) ``checkCrossDBInvalidations`` suffered spurious failures too often
+  on slow and/or busy machines.  The test is willing to wait longer for
+  success now.
+
+
 What's new in ZODB3 3.4b1?
 ==========================
 Release date: 19-May-2005

Modified: ZODB/trunk/src/ZEO/tests/ConnectionTests.py
===================================================================
--- ZODB/trunk/src/ZEO/tests/ConnectionTests.py	2005-06-06 16:32:13 UTC (rev 30658)
+++ ZODB/trunk/src/ZEO/tests/ConnectionTests.py	2005-06-06 16:36:26 UTC (rev 30659)
@@ -651,10 +651,13 @@
         transaction.commit()
 
         # Make sure the invalidation is received in the other client.
-        for i in range(10):
+        # We've had problems with this timing out on "slow" and/or "very
+        # busy" machines, so we increase the sleep time on each trip, and
+        # are willing to wait quite a long time.
+        for i in range(20):
             if r1._p_state == -1:
                 break
-            time.sleep(0.1)
+            time.sleep(i / 10.0)
         self.assertEqual(r1._p_state, -1) # ghost
 
         r1.keys() # unghostify



More information about the Zodb-checkins mailing list