[Zodb-checkins] SVN: ZODB/branches/blob-merge-branch/src/ZEO/ Mac OS X uses EINVAL to signal timeout failure.

Chris McDonough chrism at plope.com
Mon Feb 27 00:08:08 EST 2006


Log message for revision 65509:
  Mac OS X uses EINVAL to signal timeout failure.
  
  Formatting changes.
  

Changed:
  U   ZODB/branches/blob-merge-branch/src/ZEO/ClientStorage.py
  U   ZODB/branches/blob-merge-branch/src/ZEO/tests/forker.py

-=-
Modified: ZODB/branches/blob-merge-branch/src/ZEO/ClientStorage.py
===================================================================
--- ZODB/branches/blob-merge-branch/src/ZEO/ClientStorage.py	2006-02-27 04:49:31 UTC (rev 65508)
+++ ZODB/branches/blob-merge-branch/src/ZEO/ClientStorage.py	2006-02-27 05:08:07 UTC (rev 65509)
@@ -315,8 +315,7 @@
         self._lock = threading.Lock()
 
         # XXX need to check for POSIX-ness here
-        if blob_dir is not None and \
-           (os.stat(blob_dir).st_mode & 077) != 0:
+        if blob_dir is not None and (os.stat(blob_dir).st_mode & 077) != 0:
             log2('Blob dir %s has insecure mode setting' % blob_dir,
                  level=logging.WARNING)
 
@@ -978,7 +977,8 @@
             3. If not beeing downloaded, start download
         """
         if self.blob_dir is None:
-            raise POSException.Unsupported("No blob cache directory is configured. Can not load blob.")
+            raise POSException.Unsupported("No blob cache directory is "
+                                           "configured.")
 
         blob_filename = self._getCleanFilename(oid, serial)
         # Case 1: Blob is available already, just use it

Modified: ZODB/branches/blob-merge-branch/src/ZEO/tests/forker.py
===================================================================
--- ZODB/branches/blob-merge-branch/src/ZEO/tests/forker.py	2006-02-27 04:49:31 UTC (rev 65508)
+++ ZODB/branches/blob-merge-branch/src/ZEO/tests/forker.py	2006-02-27 05:08:07 UTC (rev 65509)
@@ -185,6 +185,10 @@
                 break
             raise
         except socket.error, e:
+            # Mac OS X uses EINVAL to signal unbound socket timeout failure
+            if sys.platform == 'darwin': 
+                if e[0] == errno.EINVAL and i > 0:
+                    break
             if e[0] == errno.ECONNREFUSED and i > 0:
                 break
             raise



More information about the Zodb-checkins mailing list