[Zodb-checkins] SVN: ZODB/branches/3.7/ fsrefs.py was reporting spurious 'missing' classes.

Tres Seaver tseaver at palladion.com
Thu Jul 27 18:25:13 EDT 2006


Log message for revision 69279:
  fsrefs.py was reporting spurious 'missing' classes.

Changed:
  U   ZODB/branches/3.7/NEWS.txt
  U   ZODB/branches/3.7/src/scripts/fsrefs.py

-=-
Modified: ZODB/branches/3.7/NEWS.txt
===================================================================
--- ZODB/branches/3.7/NEWS.txt	2006-07-27 21:58:05 UTC (rev 69278)
+++ ZODB/branches/3.7/NEWS.txt	2006-07-27 22:25:12 UTC (rev 69279)
@@ -74,6 +74,10 @@
 Tools
 -----
 
+- (3.7b2) Fixed bug in 'fsrefs.py' which caused it to report erroneous
+  "missing" classes.
+
+
 - (3.7a1) The changeover from zLOG to the logging module means that some
   tools need to perform minimal logging configuration themselves. Changed
   the zeoup script to do so and thus enable it to emit error messages.

Modified: ZODB/branches/3.7/src/scripts/fsrefs.py
===================================================================
--- ZODB/branches/3.7/src/scripts/fsrefs.py	2006-07-27 21:58:05 UTC (rev 69278)
+++ ZODB/branches/3.7/src/scripts/fsrefs.py	2006-07-27 22:25:12 UTC (rev 69279)
@@ -129,11 +129,8 @@
         data, serial = fs.load(oid, "")
         refs = get_refs(data)
         missing = [] # contains 3-tuples of oid, klass-metadata, reason
-        for info in refs:
-            ref, klass = info
+        for ref, klass in refs:
             if klass is None:
-                # failed to unpack
-                ref = info
                 klass = '<unknown>'
             if ref not in fs._index:
                 missing.append((ref, klass, "missing"))



More information about the Zodb-checkins mailing list