[Zodb-checkins] SVN: ZODB/branches/blob-merge-branch/src/ZODB/Blobs/BlobStorage.py only acquire a lock when we also plan to close it

Wolfgang Schnerring wosc at wosc.de
Mon Sep 25 05:35:36 EDT 2006

Log message for revision 70360:
  only acquire a lock when we also plan to close it

  U   ZODB/branches/blob-merge-branch/src/ZODB/Blobs/BlobStorage.py

Modified: ZODB/branches/blob-merge-branch/src/ZODB/Blobs/BlobStorage.py
--- ZODB/branches/blob-merge-branch/src/ZODB/Blobs/BlobStorage.py	2006-09-25 08:54:07 UTC (rev 70359)
+++ ZODB/branches/blob-merge-branch/src/ZODB/Blobs/BlobStorage.py	2006-09-25 09:35:35 UTC (rev 70360)
@@ -67,10 +67,10 @@
         assert isinstance(serial, str) # XXX in theory serials could be 
                                        # something else
-        self._lock_acquire()
         # the user may not have called "open" on the blob object,
         # in which case, the blob will not have a filename.
         if blobfilename is not None:
+            self._lock_acquire()
                 targetpath = self.fshelper.getPathForOID(oid)
                 if not os.path.exists(targetpath):

More information about the Zodb-checkins mailing list