[Zodb-checkins]
SVN: ZODB/branches/zagy-after-commit/src/transaction/
calling afterCommit hook on abort
Christian Zagrodnick
cz at gocept.com
Tue Sep 18 08:07:02 EDT 2007
Log message for revision 79736:
calling afterCommit hook on abort
Changed:
U ZODB/branches/zagy-after-commit/src/transaction/_transaction.py
U ZODB/branches/zagy-after-commit/src/transaction/tests/test_transaction.py
-=-
Modified: ZODB/branches/zagy-after-commit/src/transaction/_transaction.py
===================================================================
--- ZODB/branches/zagy-after-commit/src/transaction/_transaction.py 2007-09-18 12:06:26 UTC (rev 79735)
+++ ZODB/branches/zagy-after-commit/src/transaction/_transaction.py 2007-09-18 12:07:02 UTC (rev 79736)
@@ -480,6 +480,8 @@
self.log.error("Failed to abort resource manager: %s",
rm, exc_info=sys.exc_info())
+ self._callAfterCommitHooks(status=False)
+
if self._manager:
self._manager.free(self)
Modified: ZODB/branches/zagy-after-commit/src/transaction/tests/test_transaction.py
===================================================================
--- ZODB/branches/zagy-after-commit/src/transaction/tests/test_transaction.py 2007-09-18 12:06:26 UTC (rev 79735)
+++ ZODB/branches/zagy-after-commit/src/transaction/tests/test_transaction.py 2007-09-18 12:07:02 UTC (rev 79736)
@@ -763,13 +763,14 @@
["True arg 'A' kw1 'B' kw2 'no_kw2'"]
>>> reset_log()
- If a transaction is aborted, no hook is called.
+ If a transaction is aborted, the hook is called with False:
>>> t = transaction.begin()
>>> t.addAfterCommitHook(hook, ["OOPS!"])
>>> transaction.abort()
>>> log
- []
+ ["False arg 'OOPS!' kw1 'no_kw1' kw2 'no_kw2'"]
+ >>> reset_log()
>>> transaction.commit()
>>> log
[]
More information about the Zodb-checkins
mailing list