[Zodb-checkins] Re: [Checkins] SVN: ZODB/trunk/src/ZEO/ClientStorage.py Fix references to POSKeyError

[Christian Theune]

Jacob Holm schrieb:
> Log message for revision 83196:
>   Fix references to POSKeyError
>   
>   
> 
> Changed:
>   U   ZODB/trunk/src/ZEO/ClientStorage.py
> 
> -=-
> Modified: ZODB/trunk/src/ZEO/ClientStorage.py
> ===================================================================
> --- ZODB/trunk/src/ZEO/ClientStorage.py	2008-01-24 22:51:09 UTC (rev 83195)
> +++ ZODB/trunk/src/ZEO/ClientStorage.py	2008-01-25 01:29:46 UTC (rev 83196)
> @@ -923,7 +923,7 @@
>          if self.shared_blob_dir:
>              # We're using a server shared cache.  If the file isn't
>              # here, it's not anywhere.
> -            raise POSKeyError("No blob file", oid, serial)
> +            raise POSException.POSKeyError("No blob file", oid, serial)
>  
>          # First, we'll create the directory for this oid, if it doesn't exist. 
>          targetpath = self.fshelper.getPathForOID(oid)
> @@ -986,7 +986,7 @@
>              if self._have_blob(blob_filename, oid, serial):
>                  return blob_filename
>  
> -            raise POSKeyError("No blob file", oid, serial)
> +            raise POSException.POSKeyError("No blob file", oid, serial)

Hmm. This looks like this wasn't covered by unit tests. We should add those.

Also, if this is a bug, then it needs to be backported.

Christian

-- 
gocept gmbh & co. kg - forsterstrasse 29 - 06112 halle (saale) - germany
www.gocept.com - ct at gocept.com - phone +49 345 122 9889 7 -
fax +49 345 122 9889 1 - zope and plone consulting and development