[Zodb-checkins] SVN: ZODB/trunk/src/ZEO/StorageServer.py Explain some puzzling code :)

Jim Fulton jim at zope.com
Sun Sep 12 07:56:48 EDT 2010


Log message for revision 116302:
  Explain some puzzling code :)
  

Changed:
  U   ZODB/trunk/src/ZEO/StorageServer.py

-=-
Modified: ZODB/trunk/src/ZEO/StorageServer.py
===================================================================
--- ZODB/trunk/src/ZEO/StorageServer.py	2010-09-12 08:52:28 UTC (rev 116301)
+++ ZODB/trunk/src/ZEO/StorageServer.py	2010-09-12 11:56:47 UTC (rev 116302)
@@ -920,6 +920,12 @@
     def _setup_invq(self, name, storage):
         lastInvalidations = getattr(storage, 'lastInvalidations', None)
         if lastInvalidations is None:
+            # Using None below doesn't look right, but the first
+            # element in invq is never used.  See get_invalidations.
+            # (If it was used, it would generate an error, which would
+            # be good. :) Doing this allows clients that were up to
+            # date when a server was restarted to pick up transactions
+            # it subsequently missed.
             self.invq[name] = [(storage.lastTransaction(), None)]
         else:
             self.invq[name] = list(



More information about the Zodb-checkins mailing list