[ZODB-Dev] Re: micro patch to OFS
Tres Seaver
tseaver at palladion.com
Sun Jul 23 12:46:40 EDT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Russ Ferriday wrote:
> Hello all!
> I've spent a frustrating hour tracing the repercussions of a module name
> change in a Product on Zope 2.9.3. The problem was visible only on
> uninstall.
> No need to go into all the details, but the tiny piece of additional
> information (in this case, the class name) given by this patch gave me
> just the clue I needed. To make things easier for the next guy, I offer
> it for inclusion, with no reservations.
> Would one of you Zope committers like to vet and apply it?
>
> In zope/lib/python/OFS:
>
> diff -u Uninstalled.py.orig Uninstalled.py
> --- Uninstalled.py.orig 2006-07-23 17:06:43.000000000 +0100
> +++ Uninstalled.py 2006-07-23 16:38:38.000000000 +0100
> @@ -38,7 +38,8 @@
> raise SystemError, (
> """This object was originally created by a product that
> is no longer installed. It cannot be updated.
> - """ )
> + %s
> + """ % repr(self) )
> def __getattr__(self, name):
> if name[:3]=='_p_':
It looks fine to me. This list (the ZODB list) is probably not an ideal
location for the patch, which would be:
http://www.zope.org/Collectors/Zope/
as that will perpetuate the motivation and give us something to point at
in the changelog.
BTW, some might call your change a "feature": I would back
characterizing it as a bugfix (and describing the defect). As such, we
can then deploy it into release line code, rather than only on the trunk.
Tres.
- --
===================================================================
Tres Seaver +1 202-558-7113 tseaver at palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEw6fw+gerLs4ltQ4RAlzsAKCbX+XaCFwkgCh3IEyRqo5gh2eSegCfar5V
loNT0kZBBRxqGiddA/jmF6g=
=lLXL
-----END PGP SIGNATURE-----
More information about the ZODB-Dev
mailing list