[ZODB-Dev] zodbupdate branch sylvain-persistent-load
Christian Theune
ct at gocept.com
Tue Feb 2 05:30:41 EST 2010
On 02/02/2010 11:17 AM, Sylvain Viollon wrote:
> On Tuesday 02 February 2010 09:08:42 Christian Theune wrote:
>> Hi,
>>
>>
>
> Hello,
>
>> I think I'm fine with your approach in general by now. I don't have the
>> time to review anything, though. The old version is happily there in SVN.
>>
>> IIRC you hadn't updated all unit tests last time, did you catch up with
>> that yet?
>>
>
> I fixed the current tests yesterday. I removed a bunch of them a while ago,
> all the one which was testing the pickle modification code, since I removed
> the corresponding code.
>
> I plan to add a few more today,
>
>> Otherwise, feel free to merge and release.
>>
>
> Thank you, I think I will have look at the trunk, but if there is no changes
> in it since my branch, I will move it as a branch called pickle-version, and
> rename my branch as trunk. I will tag it, but if you want me to do the
> release, you need to give me rights on pypi. My username is thefunny42.
Meh. That looks quirky in the history. If there are no changes, then the
merge will be straight-forward.
Christian
--
Christian Theune · ct at gocept.com
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1
Zope and Plone consulting and development
More information about the ZODB-Dev
mailing list