[ZODB-Dev] Storage iterators and IndexError

Jim Fulton jim at zope.com
Mon May 17 15:18:23 EDT 2010


On Sat, May 15, 2010 at 6:43 AM, Christian Theune <ct at gocept.com> wrote:
> On 05/14/2010 08:43 PM, Jim Fulton wrote:
>> The file storage iterator was implemented before Python had iterators.
>> (Actually, Python previously had an iterator based on a corner
>> of the sequence protocol, which FileStorage used.)
>>
>> There's a test for storage iterators that verifies that they raise
>> a special exception that extends StopIteration and IndexError.
>> This makes storage iterators a bit harder to implement than
>> necessary.
>>
>> Does anyone know of a reason why we should have to raise
>> a special error that raises IndexErrors?
>
> My first thought was backwards compatibility to something and the
> docstring of the StorageStopIteration says so but doesn't tall for what.
>
> Sounds like support for old clients but I can't say for which use case.

OK, I'm going to try getting rid of StorageStopIteration.  If getting
rid of it breaks
anything, we may call the removal a bug and put it back. :)

Jim

-- 
Jim Fulton


More information about the ZODB-Dev mailing list