[ZODB-Dev] Default comparison considered harmful in BTrees.

Jim Fulton jim at zope.com
Thu Oct 28 09:44:50 EDT 2010


On Thu, Oct 28, 2010 at 8:27 AM, Hanno Schlichting <hanno at hannosch.eu> wrote:
> On Wed, Oct 27, 2010 at 8:56 PM, Jim Fulton <jim at zope.com> wrote:

...

>> As I said earlier, in 3.11, it will be an error to use an object with
>> default comparison as a key, but loading state with such objects will
>> only warn.

Looking at this a bit more. I decided I'll only error when updating
a BTree or set using __setitem__ or add.  So even in 3.11, you won't
get an error when loading an object or using an invalid key in a query method.
You will still get a warning,

> I agree with them being useful. And once I'm not busy at the
> conference, I'll give it more proper testing.

Thanks.  Note that to get at the version you were playing with, you'll need
to select a specific svn revision, as I reverted the relevant changes from
the 3.10 branch.  I exhausted by time budget for this and it may take a few days
before I get changes back on the 3.10 branch (and refine my changes on the
trunk).

Jim

-- 
Jim Fulton


More information about the ZODB-Dev mailing list