[ZODB-Dev] transaction "Attempts" class

[Jim Fulton]

On Wed, Mar 28, 2012 at 4:37 PM, Chris McDonough <chrism at plope.com> wrote:
> On Wed, 2012-03-28 at 14:21 -0400, Jim Fulton wrote:
...
> A decorator for running some code in the context of a txn and retrying
> retryable exceptions would be nice higher level behavior. Â I'd be
> willing to do this work over this weekend.

Cool.  Don't forget the transaction note part. :)
Too many transactions in our apps don't have
notes, especially transactions that happen
outside of web requests.

> In the meantime, I think the existing attempts context manager still
> needs the small fix I proposed in my original message. Â Can you confirm
> that my understanding of the its intent seems roughly correct?

I didn't see a statement of intent.  I think your fix us good,
but the code (that I wrote and your fix) makes my head hurt. :)

I'd say, make some test cases for the bug and make it pass.

I'll admit, I didn't understand "Either that or it needs to not try to
do a commit itself, and leave it up to the caller."

Jim

--
Jim Fulton
http://www.linkedin.com/in/jimfulton