[ZODB-Dev] [zopefoundation/zodbpickle] 661e8b: Add minimal tests and Python ref. impl. for 'noloa...

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/06/2013 06:29 AM, Marius Gedminas wrote:
> On Tue, Mar 05, 2013 at 05:05:36PM -0800, GitHub wrote:
>> Branch: refs/heads/master Home:
>> https://github.com/zopefoundation/zodbpickle Commit:
>> 661e8b78f91a9e77da739c2f1d00780ad24d1efa 
>> https://github.com/zopefoundation/zodbpickle/commit/661e8b78f91a9e77da739c2f1d00780ad24d1efa
>>
>> 
Author: Tres Seaver <tseaver at palladion.com>
>> Date:   2013-03-05 (Tue, 05 Mar 2013)
>> 
>> Changed paths: M src/zodbpickle/pickle.py M
>> src/zodbpickle/tests/pickletester.py
>> 
>> Log Message: ----------- Add minimal tests and Python ref. impl. for
>> 'noload'.
> 
> Thank you, this made my day!
> 
> BTW I've a plan for Python 3.2 compatibility in zodbpickle: move the
> new features (noload, bytes_as_strings) into _pickle_32.c, rename it
> to _pickle.c, then drop _pickle_33.c and the corresponding tests for 
> 3.3-only features.
> 
> We're not using any of the new pickle features introduced in Python
> 3.3, and I don't like to see an external package like zodbpickle
> using undocumented internal CPython APIs like _Py_IDENTIFIER.

Sounds good to me.  Note that the test coverage for the Python reference
implementation is not great (and not just for 'noload*').


Tres.
- -- 
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlE3z4UACgkQ+gerLs4ltQ565wCgsk8K0qMqGA3FHUqXx3F5G09s
5D0AoJZep0kkI/S4mvxf8eBY9g62C5Tk
=AIxH
-----END PGP SIGNATURE-----