[Zope-Checkins] CVS: Zope/lib/python/AccessControl - User.py:1.161

[Andreas Jung]

Update of /cvs-repository/Zope/lib/python/AccessControl
In directory cvs.zope.org:/tmp/cvs-serv6285/lib/python/AccessControl

Modified Files:
	User.py 
Log Message:
- simplified domainsSpecValidate()
- better regular expressions to check hostnames and domain specs
- added underscore as allowed character in hostnames (this is officially
  forbidden by RFC 972 but underscores are often used and supported
  by some DNS servers).


=== Zope/lib/python/AccessControl/User.py 1.160 => 1.161 ===
         return AuthEncoding.pw_encrypt(pw, 'SSHA')
 
-    def domainSpecValidate(self, spec):
+
+    def domainSpecValidate(spec):
+
         for ob in spec:
-            sz=len(ob)
+
             am = addr_match(ob)
             hm = host_match(ob)
-            if am or hm:
-                if am: am = am.end()
-                else: am = -1
-                if hm: hm = hm.end()
-                else: hm = -1
-                if not ( (am == sz) or (hm == sz) ):
-                    return 0
+
+            if am is None and hm is None:
+                return 0
+
         return 1
 
+
     def _addUser(self,name,password,confirm,roles,domains,REQUEST=None):
         if not name:
             return MessageDialog(
@@ -1159,14 +1159,15 @@
     roles.sort()
     return roles
 
-addr_match=re.compile(r'[\d.]*').match
-host_match=re.compile(r'[-\w.]*').match
+addr_match=re.compile(r'((\d{1,3}\.){1,3}\*)|((\d{1,3}\.){3}\d{1,3})').match
+host_match=re.compile(r'(([\_0-9a-zA-Z\-]*\.)*[0-9a-zA-Z\-]*)').match
+
+
 
 def domainSpecMatch(spec, request):
     host=''
     addr=''
 
-    
     # Fast exit for the match-all case
     if len(spec) == 1 and spec[0] == '*':
         return 1