[Zope-Checkins] CVS: Zope3/src/transaction - _transaction.py:1.3

Tim Peters tim.one at comcast.net
Fri Apr 2 14:48:24 EST 2004


Update of /cvs-repository/Zope3/src/transaction
In directory cvs.zope.org:/tmp/cvs-serv23772/src/transaction

Modified Files:
	_transaction.py 
Log Message:
Added XXX comments about stray output produced by
testExceptionInTpcAbort().  The cause is clear now, but a solution isn't;
an exception in tpc_abort is nasty.


=== Zope3/src/transaction/_transaction.py 1.2 => 1.3 ===
--- Zope3/src/transaction/_transaction.py:1.2	Wed Mar 31 22:56:56 2004
+++ Zope3/src/transaction/_transaction.py	Fri Apr  2 14:48:23 2004
@@ -324,11 +324,13 @@
                 try:
                     rm.abort_sub(self)
                 except Exception, err:
+                    # XXX Just printing the error doesn't seem good enough.
                     print err
             else:
                 try:
                     rm.tpc_abort(self)
                 except Exception, err:
+                    # XXX Just printing the error doesn't seem good enough.
                     print err
 
     def _getResourceManagers(self, subtransaction):
@@ -498,7 +500,7 @@
         self.manager.tpc_finish(txn)
         if self.sub:
             self.objects = []
-            
+
 
 def rm_cmp(rm1, rm2):
     return cmp(rm1.sortKey(), rm2.sortKey())
@@ -534,7 +536,7 @@
     def __init__(self, datamanager):
         self._datamanager = datamanager
         self._rollback = None
-        
+
     # XXX I'm not sure why commit() doesn't do anything
 
     def commit(self, transaction):
@@ -558,7 +560,7 @@
         # Nothing to do wrt data, be we begin 2pc for the top-level
         # trans
         self._sub = False
-        
+
     def tpc_begin(self, transaction, subtransaction=False):
         self._sub = subtransaction
 




More information about the Zope-Checkins mailing list