[Zope-Checkins] CVS: Zope/lib/python/Products/Transience/tests - testTransientObjectContainer.py:1.15

[Tim Peters]

Update of /cvs-repository/Zope/lib/python/Products/Transience/tests
In directory cvs.zope.org:/tmp/cvs-serv1044/lib/python/Products/Transience/tests

Modified Files:
	testTransientObjectContainer.py 
Log Message:
testPathologicalRightBranching(), testPathologicalLeftBranching():  Note
that these tests can fail for bogus reasons.  Jeremy saw them failing
today, and it took a while to figure out that this had nothing to do with
the ZODB changes he was making.


=== Zope/lib/python/Products/Transience/tests/testTransientObjectContainer.py 1.14 => 1.15 ===
--- Zope/lib/python/Products/Transience/tests/testTransientObjectContainer.py:1.14	Thu May 15 11:21:53 2003
+++ Zope/lib/python/Products/Transience/tests/testTransientObjectContainer.py	Thu Feb 26 16:37:28 2004
@@ -220,13 +220,23 @@
 
     def testPathologicalRightBranching(self):
         r = range(10, 1010)
+        # NOTE:  If the process running this test swaps out inside the loop,
+        # it can easily cause the test to fail, with a prefix of the expected
+        # keys missing (the keys added before the interruption expire by the
+        # time they're checked).  This can happen with interruptions of less
+        # than 1 wall-clock second, so can and does happen.
         for x in r:
             self.t[x] = 1
         assert list(self.t.keys()) == r, (self.t.keys(), r)
+        # NOTE:  The next line may fail even if the line above succeeds:  if
+        # the key age is such that keys *start* to expire right after
+        # list(self.t.keys()) completes, keys can vanish before __delitem__
+        # gets to them.
         map(self.t.__delitem__, r)
         assert list(self.t.keys()) == [], self.t.keys()
 
     def testPathologicalLeftBranching(self):
+        # See notes for testPathologicalRightBranching.
         r = range(10, 1010)
         revr = r[:]
         revr.reverse()