[Zope-Checkins] CVS: Zope3/src/ZODB - Connection.py:1.114.2.1 coptimizations.c:1.26.6.1 serialize.py:1.2.10.1

Jeremy Hylton jeremy at zope.com
Fri Jan 9 14:54:53 EST 2004


On Fri, 2004-01-09 at 14:48, Fred L. Drake, Jr. wrote:
> Update of /cvs-repository/Zope3/src/ZODB
> In directory cvs.zope.org:/tmp/cvs-serv30152
> 
> Modified Files:
>       Tag: zope3-zodb3-devel-branch
> 	Connection.py coptimizations.c serialize.py 
> Log Message:
> checkpoint changes to change the ZODB format
> 
> 
> === Zope3/src/ZODB/Connection.py 1.114 => 1.114.2.1 ===
> --- Zope3/src/ZODB/Connection.py:1.114	Tue Jan  6 13:10:43 2004
> +++ Zope3/src/ZODB/Connection.py	Fri Jan  9 14:48:53 2004
> @@ -19,28 +19,20 @@
>  import sys
>  import threading
>  from time import time
> -from types import ClassType
>  from utils import u64
>  
> -_marker = object()
> -
> -def myhasattr(obj, attr):
> -    # builtin hasattr() swallows exceptions
> -    return getattr(obj, attr, _marker) is not _marker

I'd prefer you to leave myhasattr() in the code.  I've wasted days of my
life tracking down bugs caused by hasattr()s that swallowed exceptions.

Jeremy





More information about the Zope-Checkins mailing list