[Zope-Checkins] SVN: Zope/trunk/ - Merge forward test and fix for Collector #1667.

[Tres Seaver]

Log message for revision 28861:
   - Merge forward test and fix for Collector #1667.

Changed:
  U   Zope/trunk/doc/CHANGES.txt
  U   Zope/trunk/lib/python/OFS/Application.py
  U   Zope/trunk/lib/python/OFS/tests/testAppInitializer.py

-=-
Modified: Zope/trunk/doc/CHANGES.txt
===================================================================
--- Zope/trunk/doc/CHANGES.txt	2005-01-18 01:01:50 UTC (rev 28860)
+++ Zope/trunk/doc/CHANGES.txt	2005-01-18 16:48:30 UTC (rev 28861)
@@ -51,6 +51,11 @@
 
     Bugs fixed
 
+      - Collector #1667: allow 'max-number-of-session-objects 0' to have
+        the same effect as setting the value via the web interface (i.e.,
+        make the number of session objects unlimited, rather than falling
+        back to the default).
+
       - Collector: #1651: removed compiler warning 
 
       - Collector #1661: make 'python-check-interval' setting in zope.conf

Modified: Zope/trunk/lib/python/OFS/Application.py
===================================================================
--- Zope/trunk/lib/python/OFS/Application.py	2005-01-18 01:01:50 UTC (rev 28860)
+++ Zope/trunk/lib/python/OFS/Application.py	2005-01-18 16:48:30 UTC (rev 28861)
@@ -380,8 +380,8 @@
             default_period_secs = 20
             default_timeout_mins = 20
 
-            limit = (getattr(config, 'maximum_number_of_session_objects', None)
-                     or default_limit)
+            limit = getattr(config, 'maximum_number_of_session_objects', 
+                            default_limit)
             timeout_spec = getattr(config, 'session_timeout_minutes',
                                    default_timeout_mins)
             period_spec = getattr(config, 'session_resolution_seconds',

Modified: Zope/trunk/lib/python/OFS/tests/testAppInitializer.py
===================================================================
--- Zope/trunk/lib/python/OFS/tests/testAppInitializer.py	2005-01-18 01:01:50 UTC (rev 28860)
+++ Zope/trunk/lib/python/OFS/tests/testAppInitializer.py	2005-01-18 16:48:30 UTC (rev 28861)
@@ -121,6 +121,18 @@
         status = i.install_tempfolder_and_sdc()
         self.failIf(status)
 
+    def test_install_tempfolder_and_sdc_unlimited_sessions(self):
+        unlimited_cfg = good_cfg + """
+        maximum-number-of-session-objects 0
+        """
+        self.configure(unlimited_cfg)
+        i = self.getOne()
+        status = i.install_tempfolder_and_sdc()
+        self.failUnless(status)
+
+        sdc = i.getApp().temp_folder.session_data
+        self.assertEqual(sdc.getSubobjectLimit(), 0)
+
     def test_install_browser_id_manager(self):
         self.configure(good_cfg)
         i = self.getOne()