[Zope-Checkins] CVS: Packages/App - Management.py:1.61.68.5

Chris McDonough chrism at plope.com
Tue Jul 5 22:03:50 EDT 2005


Update of /cvs-repository/Packages/App
In directory cvs.zope.org:/tmp/cvs-serv20396

Modified Files:
      Tag: Zope-2_7-branch
	Management.py 
Log Message:
Remove two bare except: clauses and comment on another.



=== Packages/App/Management.py 1.61.68.4 => 1.61.68.5 ===
--- Packages/App/Management.py:1.61.68.4	Thu Jan  8 18:33:45 2004
+++ Packages/App/Management.py	Tue Jul  5 22:03:49 2005
@@ -41,7 +41,7 @@
 
         try:
             options=tuple(self.manage_options)
-        except:
+        except TypeError:
             options=tuple(self.manage_options())
 
         for d in options:
@@ -61,7 +61,7 @@
             try:
                 if validate(None, self, None, o):
                     result.append(d)
-            except:
+            except: # XXX wtf are we trying to check for here?
                 if not hasattr(o, '__roles__'):
                     result.append(d)
 
@@ -77,7 +77,7 @@
             m=options[0]['action']
             if m=='manage_workspace':
                     raise TypeError
-        except:
+        except (KeyError, IndexError):
             raise Unauthorized, (
                 'You are not authorized to view this object.')
 



More information about the Zope-Checkins mailing list