[Zope-Checkins] SVN: Zope/trunk/lib/python/OFS/Image.py Collector
http://www.zope.org/Collectors/Zope/1797 : 304 responses
require collaboration from http accelerated cache manager.
(see also http://www.zope.org/Collectors/Zope/683).
Chris McDonough
chrism at plope.com
Fri Jun 3 12:19:54 EDT 2005
Log message for revision 30624:
Collector http://www.zope.org/Collectors/Zope/1797 : 304 responses require collaboration from http accelerated cache manager. (see also http://www.zope.org/Collectors/Zope/683).
Changed:
U Zope/trunk/lib/python/OFS/Image.py
-=-
Modified: Zope/trunk/lib/python/OFS/Image.py
===================================================================
--- Zope/trunk/lib/python/OFS/Image.py 2005-06-03 15:22:18 UTC (rev 30623)
+++ Zope/trunk/lib/python/OFS/Image.py 2005-06-03 16:19:53 UTC (rev 30624)
@@ -365,6 +365,12 @@
if self._if_modified_since_request_handler(REQUEST, RESPONSE):
# we were able to handle this by returning a 304
+ # unfortunately, because the HTTP cache manager uses the cache
+ # API, and because 304 responses are required to carry the Expires
+ # header for HTTP/1.1, we need to call ZCacheable_set here.
+ # This is nonsensical for caches other than the HTTP cache manager
+ # unfortunately.
+ self.ZCacheable_set(None)
return ''
if self.precondition and hasattr(self, str(self.precondition)):
More information about the Zope-Checkins
mailing list