[Zope-Checkins] SVN: Zope/trunk/ - The ZEO server now records its PID to a file like the ZEO

[Fred Drake]

On Thu, 17 Mar 2005 16:30:49 -0500, Tim Peters <tim.peters at gmail.com> wrote:
> I suspect we would regret exempting Windows here.  Mark Hammond has
> had several important patches backed up in the Collector for months,
> aiming at improving how Zope runs on Windows, and ZEO too.  At least
> the latter starts to give ZEO some limited signal-handling smarts on
> Windows.

Yeah; someone with time needs to look at those.

> The pid _concept_ makes sense on Windows too -- although
> it's confused by that Windows has both "process identifiers" and
> "process handles", both of which look like integers.

Ok.

> In any case, I don't see how the code here could get any simpler, or
> more correct, by adding "is it Windows?" tests; and except _perhaps_
> for using text mode to open the pid file for writing, nothing here is
> Linux-specific.

The pid files should be opened as text files.  Opinions differ
regarding whether a newline should follow the pid, however.  (I'm in
the pro-newline camp, myself, simply because it makes it easier to
read the output of "cat pidfile" on Unix.)


  -Fred

-- 
Fred L. Drake, Jr.    <fdrake at gmail.com>
Zope Corporation