[Zope-Checkins] SVN: Zope/trunk/lib/python/Products/ZCatalog/Catalog.py added comment to weird code

Andreas Jung andreas at andreas-jung.com
Tue Nov 1 05:18:53 EST 2005


Log message for revision 39804:
  added comment to weird code 
  

Changed:
  U   Zope/trunk/lib/python/Products/ZCatalog/Catalog.py

-=-
Modified: Zope/trunk/lib/python/Products/ZCatalog/Catalog.py
===================================================================
--- Zope/trunk/lib/python/Products/ZCatalog/Catalog.py	2005-11-01 03:24:00 UTC (rev 39803)
+++ Zope/trunk/lib/python/Products/ZCatalog/Catalog.py	2005-11-01 10:18:52 UTC (rev 39804)
@@ -491,6 +491,8 @@
         elif rs:
             # We got some results from the indexes.
             # Sort and convert to sequences.
+            # XXX: The check for 'values' is really stupid since we call
+            # items() and *not* values()
             if sort_index is None and hasattr(rs, 'values'):
                 # having a 'values' means we have a data structure with
                 # scores.  Build a new result set, sort it by score, reverse



More information about the Zope-Checkins mailing list