[Zope-Checkins] SVN: Zope/trunk/lib/python/Products/Sessions/tests/testSessionDataManager.py Convert subtransaction commits to savepoint creations.

[Tim Peters]

Log message for revision 39727:
  Convert subtransaction commits to savepoint creations.
  
  Stops deprecation warnings from ZODB 3.6.
  
  Still no idea why deprecation warnings from the ZODB tests
  show up (ZODB is already trying to suppress them, and that
  works fine in a ZODB checkout and in a Zope3 checkout).
  

Changed:
  U   Zope/trunk/lib/python/Products/Sessions/tests/testSessionDataManager.py

-=-
Modified: Zope/trunk/lib/python/Products/Sessions/tests/testSessionDataManager.py
===================================================================
--- Zope/trunk/lib/python/Products/Sessions/tests/testSessionDataManager.py	2005-10-29 23:54:14 UTC (rev 39726)
+++ Zope/trunk/lib/python/Products/Sessions/tests/testSessionDataManager.py	2005-10-30 02:25:54 UTC (rev 39727)
@@ -50,7 +50,7 @@
         root = conn.root()
         app = Application()
         root['Application']= app
-        transaction.commit(1)
+        transaction.savepoint(optimistic=True)
         _populate(app)
         stuff['db'] = db
         conn.close()
@@ -188,9 +188,10 @@
     def testSubcommit(self):
         sd = self.app.session_data_manager.getSessionData()
         sd.set('foo', 'bar')
-        # TODO: transaction.commit() always returns None.  Is that
-        # all this is trying to test?
-        self.failUnless(transaction.commit(1) == None)
+        # TODO: this is used to test that transaction.commit(1) returned
+        # None, but transaction.commit(whatever) always returns None (unless
+        # there's an exception).  What is this really trying to test?
+        transaction.savepoint(optimistic=True)
 
     def testForeignObject(self):
         self.assertRaises(InvalidObjectReference, self._foreignAdd)