[Zope-Checkins] SVN: Products.Five/trunk/ Fixed an issue where <browser:page> based views that didn't have template or attribute defined weren't getting BrowserView mixed in.

[Rocky Burt]

Log message for revision 68289:
  Fixed an issue where <browser:page> based views that didn't have template or attribute defined weren't getting BrowserView mixed in.

Changed:
  U   Products.Five/trunk/CHANGES.txt
  U   Products.Five/trunk/browser/metaconfigure.py
  U   Products.Five/trunk/browser/tests/pages.txt
  U   Products.Five/trunk/browser/tests/pages.zcml

-=-
Modified: Products.Five/trunk/CHANGES.txt
===================================================================
--- Products.Five/trunk/CHANGES.txt	2006-05-25 20:30:23 UTC (rev 68288)
+++ Products.Five/trunk/CHANGES.txt	2006-05-25 20:44:07 UTC (rev 68289)
@@ -8,6 +8,9 @@
 Bugfixes
 --------
 
+* Fixed an issue where <browser:page> based views that didn't have
+  template or attribute defined weren't getting BrowserView mixed in.
+
 * Fixed an issue where new-style classes could not be used for
   view components with <browser:page>.
 

Modified: Products.Five/trunk/browser/metaconfigure.py
===================================================================
--- Products.Five/trunk/browser/metaconfigure.py	2006-05-25 20:30:23 UTC (rev 68288)
+++ Products.Five/trunk/browser/metaconfigure.py	2006-05-25 20:44:07 UTC (rev 68289)
@@ -111,7 +111,8 @@
             # some security declarations on it so we really shouldn't
             # modify the original.  So, instead we make a new class
             # with just one base class -- the original
-            new_class = makeClass(class_.__name__, (class_,), cdict)
+            new_class = makeClass(class_.__name__, 
+                                  (class_, BrowserView), cdict)
 
     else:
         # template

Modified: Products.Five/trunk/browser/tests/pages.txt
===================================================================
--- Products.Five/trunk/browser/tests/pages.txt	2006-05-25 20:30:23 UTC (rev 68288)
+++ Products.Five/trunk/browser/tests/pages.txt	2006-05-25 20:44:07 UTC (rev 68289)
@@ -78,7 +78,15 @@
 
   >>> self.folder.unrestrictedTraverse('testoid/@@new_style_class')
   <Products.Five.metaclass.NewStyleClass ...>
+  
+At one point browser classes with no attribute and no template
+values specified wasn't getting BrowserView mixed in.  Lets make
+sure it is now:
 
+  >>> self.folder.unrestrictedTraverse('testoid/@@new_style_class2')
+  <Products.Five.metaclass.NewStyleClass ...>
+
+
 ZPT-based browser pages
 -----------------------
 

Modified: Products.Five/trunk/browser/tests/pages.zcml
===================================================================
--- Products.Five/trunk/browser/tests/pages.zcml	2006-05-25 20:30:23 UTC (rev 68288)
+++ Products.Five/trunk/browser/tests/pages.zcml	2006-05-25 20:44:07 UTC (rev 68289)
@@ -200,6 +200,14 @@
       permission="zope2.Public"
       />
 
+  <browser:page
+      for="Products.Five.tests.testing.simplecontent.ISimpleContent"
+      class=".pages.NewStyleClass"
+      name="new_style_class2"
+      permission="zope2.Public"
+      />
+
+
   <!-- Verify that browser:view works, especially when no specific
        view attribute is specified -->