[Zope-Checkins] SVN: Zope/branches/2.12/ LP #490514: preserve tainting when calling into DTML from ZPT.

[Tres Seaver]

Log message for revision 106134:
  LP #490514:  preserve tainting when calling into DTML from ZPT.
  
  

Changed:
  U   Zope/branches/2.12/doc/CHANGES.rst
  U   Zope/branches/2.12/src/Products/PageTemplates/ZRPythonExpr.py
  U   Zope/branches/2.12/src/Products/PageTemplates/tests/testZRPythonExpr.py

-=-
Modified: Zope/branches/2.12/doc/CHANGES.rst
===================================================================
--- Zope/branches/2.12/doc/CHANGES.rst	2009-11-30 23:19:20 UTC (rev 106133)
+++ Zope/branches/2.12/doc/CHANGES.rst	2009-11-30 23:21:51 UTC (rev 106134)
@@ -27,9 +27,12 @@
 Bugs Fixed
 ++++++++++
 
+- LP #490514:  preserve tainting when calling into DTML from ZPT.
+
 - Avoid possible errors on test tear-down in Products.Five.fiveconfigure's
   cleanUp() function if Products.meta_types has not been set
 
+
 Zope 2.12.1 (2009/11/02)
 ------------------------
 

Modified: Zope/branches/2.12/src/Products/PageTemplates/ZRPythonExpr.py
===================================================================
--- Zope/branches/2.12/src/Products/PageTemplates/ZRPythonExpr.py	2009-11-30 23:19:20 UTC (rev 106133)
+++ Zope/branches/2.12/src/Products/PageTemplates/ZRPythonExpr.py	2009-11-30 23:21:51 UTC (rev 106134)
@@ -69,6 +69,8 @@
     this = ns.get('context', ns.get('here'))
     td.this = this
     request = ns.get('request', {})
+    if hasattr(request, 'taintWrapper'):
+        request = request.taintWrapper()
     td._push(request)
     td._push(InstanceDict(td.this, td))
     td._push(ns)

Modified: Zope/branches/2.12/src/Products/PageTemplates/tests/testZRPythonExpr.py
===================================================================
--- Zope/branches/2.12/src/Products/PageTemplates/tests/testZRPythonExpr.py	2009-11-30 23:19:20 UTC (rev 106133)
+++ Zope/branches/2.12/src/Products/PageTemplates/tests/testZRPythonExpr.py	2009-11-30 23:21:51 UTC (rev 106134)
@@ -39,6 +39,18 @@
 
         result = call_with_ns(_find_request, names)
         self.assertEqual(result, {})
+
+    def test_call_with_request_preserves_tainting(self):
+        from Products.PageTemplates.ZRPythonExpr import call_with_ns
+        class Request(dict):
+            def taintWrapper(self):
+                return {'tainted': 'found'}
+        context = ['context']
+        here = ['here']
+        names = {'context' : context, 'here': here, 'request' : Request()}
+
+        found = call_with_ns(lambda td: td['tainted'], names)
+        self.assertEqual(found, 'found')
  
 def test_suite():
     return unittest.makeSuite(MiscTests)