[Zope-CMF] Bug in CMFCore.FSMetadata._securityParser

Chris Withers chrisw at nipltd.com
Tue Aug 5 12:04:47 EDT 2003


Jean Jordaan wrote:
> Hi all
> 
> Looks like FSMetadata._securityParser doesn't go all the way.
> It stores acquire as a string. The problem is that both "0"
> and "1" evaluate as true. So it's impossible to disable
> acquired permissions in .metadata files at the moment. The
> simplest fix is just to use int, which will raise a ValueError
> for illegal values ..
> 
>          acquire, roles = data.split(':')
> +        acquire = int(acquire)
> 
> (I'm using CMF 1.4)

Sounds good to me :-)

Can you write a unit test for it that fits into the current suite, and then 
insert the patch and test into the collector?

cheers,

Chris




More information about the Zope-CMF mailing list