[Zope-CMF] Re: [CMF-checkins] CVS: CMF/CMFDefault - SyndicationTool.py:1.21

[Tres Seaver]

I have a feeling that we are patching code here which would be better
removed;  in particular, I can't see any reason to declare the
'editSynProperies' method public, and then turn around and do an
unconditional permission check + raise Unauthorized as the first action
of the method.

I would prefer to check in the attached patch (for 1.3 / 1.4;  the head
needs some light sanding after applying it), which just delcares the
method protected by the same permission used in the '_checkPermission'
call;  it then rips out all the other cruft.

Any issues with that?


On Tue, 2003-12-23 at 17:02, Yvo Schubbe wrote:
> Update of /cvs-repository/CMF/CMFDefault
> In directory cvs.zope.org:/tmp/cvs-serv23966/CMFDefault
> 
> Modified Files:
> 	SyndicationTool.py 
> Log Message:
> ported sidnei's fix to HEAD
> 
> 
> === CMF/CMFDefault/SyndicationTool.py 1.20 => 1.21 ===
> --- CMF/CMFDefault/SyndicationTool.py:1.20	Mon Dec  1 08:55:43 2003
> +++ CMF/CMFDefault/SyndicationTool.py	Tue Dec 23 17:02:42 2003
> @@ -18,6 +18,7 @@
>  """
>  
>  from AccessControl import ClassSecurityInfo
> +from AccessControl import Unauthorized
>  from Acquisition import aq_base
>  from DateTime import DateTime
>  from Globals import HTMLFile

Tres.
-- 
===============================================================
Tres Seaver                                tseaver at zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: syntool.patch
Type: text/x-patch
Size: 2640 bytes
Desc: not available
Url : http://mail.zope.org/pipermail/zope-cmf/attachments/20031223/dc17cd60/syntool.bin