[Zope-CMF] Re: [CMF-checkins] CVS: CMF/CMFCore/tests - test_DirectoryView.py:1.15

[Tres Seaver]

On Mon, 2003-06-23 at 08:22, Yvo Schubbe wrote:
> Update of /cvs-repository/CMF/CMFCore/tests
> In directory cvs.zope.org:/tmp/cvs-serv32338/CMFCore/tests
> 
> Modified Files:
> 	test_DirectoryView.py 
<snip>
> @@ -45,7 +50,7 @@
>          self.ob.fake_skin.manage_properties('Products/CMFCore/tests/fake_skins/fake_skin')        
>          self.failUnless(hasattr(self.ob.fake_skin,'test1'),self.ob.fake_skin.getDirPath())
>  
> -    def test_getDirectoryInfo5( self ):
> +    def test_getDirectoryInfo4( self ):
>          """ *nix SOFTWARE_HOME  """
>          self.ob.fake_skin.manage_properties('/usr/local/zope/2.5.1/Products/CMFCore/tests/fake_skins/fake_skin')        
>          self.failUnless(hasattr(self.ob.fake_skin,'test1'),self.ob.fake_skin.getDirPath())

Thanks for fixing that bit while adding a test for the other bug.  I
presume that this change un-shadows the a test which wasn't being run
due to cut-and-paste.  I would say that using sequence numbers here,
rather than a methodd name which describes the intent of the test, is
sub-optimal.  Let's not do that any more, in hopes of making such
problems easier to spot:  cut-and-paste could still "shadow" a test
here, but human eyes are likelier to see incongruity if we give them
some more clues.

Tres.
-- 
===============================================================
Tres Seaver                                tseaver@zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com