[Zope-CMF] Re: Old code...

[Lennart Regebro]

Yuppie wrote:
> Hi!
> 
> 
> Florent Guillaume wrote:
> 
>> CMFCore/MembershipTool's addMember has since v1.1 this code:
>>
>>  else:
>>      # The acl_users folder is a LoginManager.  Search for a UserSource
>>      # with the needed support.
>>      for source in acl_users.UserSourcesGroup.objectValues():
>>          if hasattr(source, 'addUser'):
>>              source.__of__(self).addUser(id, password, roles, domains)
>>      raise "Can't add Member", "No supported UserSources"
>>
>> I think I'll remove it, seeing that it cannot ever have worked in the 
>> first place...
> 
> 
> I don't see it. Could you give me a hint?

It will always raise an error.

> +1 for removing LoginManager cruft

credentialsChanged is defined not only by LoginManager, but also by 
cookie_crumbler, I think. I don't know where it's called from, but I 
think having it on the user folder is a reasonable idea.