[Zope-CMF] Re: CVS: CMF - CHANGES.txt:1.146.4.45

[Alec Mitchell]

On Thursday 05 August 2004 05:40 am, Tres Seaver wrote:
> Stefan H. Holek wrote:
> > Update of /cvs-repository/CMF
> > In directory cvs.zope.org:/tmp/cvs-serv20599
> >
> > Modified Files:
> >       Tag: CMF-1_4-branch
> > 	CHANGES.txt
> > Log Message:
> > Implemented parts of #110 by making workflow states configurable TTW.
> Hmm, I'm not quite sure this fits the policy on the release branch,
> where stability is a driving factor.  A (notional) 1.4.7 release should
> be very low risk for a site manager to deploy (as in, she shouldn't need
> to worry about the chance that a new feature might have introduced a bug).
>
> Let's at least discuss features before backporting them in the future.

If this goes into the 1.4 branch, it would probably be wise to at least add a 
default value for 'show_states' in the 'edit_configuration' method, so that 
people who are calling it directly from python code still have the right 
number of arguments.

Some other comments about related CMFCalendar features additions:

Though the first day of the week code in the patch is not ideal (particularly 
the calls to 'calendar.setfirstweekday()' in every method), it works well, 
and serves a need that is likely even more common than the need to add custom 
workflow states.  It would be very nice to have this in 1.5.

Also, there is a an additional change I added to the patch, which created 
methods (StartDate() and EndDate()) that return the ISO string version of the 
start() and end() dates, and catalog metadata columns for those ISO date 
methods.  Ideally these would eventually replace the start() and end() 
catalog metadata (to prevent catalog metadata bloat, and bring things in line 
with the other date field metadata used in CMF).  For now, because many 
products use the start and end catalog columns, it is probably best to just 
note that they are deprecated in CHANGES/README, and give Plone, CalendarX, 
etc. some time to catch up (as was done with the DublinCore date metadata 
IIRC).

Similarly, it would be very nice if the start() and end() catalog indexes 
could be made DateIndexes, rather than bloaty FieldIndexes.  People might 
also find having a new DateRangeIndex on start() and end() useful for finding 
overlapping event objects.

I've attached a patch to HEAD, that adds the ISO date methods and metadata, 
changes the index types from Field to Date, and adds a DateRangeIndex (which 
I have found very useful in the past, though it is certainly not critical).

Alec Mitchell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ISOStrings_patch.diff
Type: text/x-diff
Size: 2111 bytes
Desc: not available
Url : http://mail.zope.org/pipermail/zope-cmf/attachments/20040805/e5c4ee9e/ISOStrings_patch.bin