[Zope-CMF] Re: [Performance] "listFilteredActionsFor" unnecessarily expensive

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dieter Maurer wrote:
> In our regular profiles, "listFilteredActionsFor" belongs to
> the top consumers of CPU time.
> 
> Recently, I found the main culprit (in CMF 1.4):
> 
>    It is the completely unnecessary:
> 
>       if not action in catlist:
> 
> In our case, "listFilteredActionsFor" spends about 70 percent
> of its complete time in the checking of "action in catlist".
> 
> How in hell should the same action be defined more than once
> such that we need to prevent such a case by an explicit check --
> especially by such an expensive one?
> 
> A comment before the line indicates that the author intended
> to check by identity. But, of course, "action in catlist"
> does *NOT* check by identity but by equality.
> 
> 
> I propose to remove the check altogether...

+1:  the check is gone in the 1.5 branch, anyway.

Note that the 1.4 branch is "unsupported", at least by me;  Sidnei and
Florent touched it last. ;)


Tres.
- --
===============================================================
Tres Seaver                                tseaver at zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCUvr1GqWXf00rNCgRAtl6AJ41VuWksQLQYyBHvpNTzq3jiGl1ggCeOlOs
8srapYqKSHe9MkL6jJtEq64=
=nBxO
-----END PGP SIGNATURE-----