[Zope-CMF] [CMF 2.1] FSPageTemplate & Unicode

[Jens Vagelpohl]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On 19 Dec 2006, at 09:45, Andreas Jung wrote:
> Jup. However I am not completely sure about all impacts :-)

If I understand the description correctly, the real change is in how  
the "surrogate" page template object representing the filesystem page  
template is created. The rendering itself is handed off to the  
pt_render method from the original PageTemplate class.

If you look at the current FSPageTemplate code, there was already an  
attempt to find and transfer enoding information with the response by  
way of adding it to the content type, see _readFile. It does preamble  
sniffing as well. That could then be replaced by your own encoding  
detection, which also uses the preamble, and .metadata information.

My quick glance doesn't show any huge issues, I only see the added  
benefit of being able to add encoding information to the .metadata file.

jens



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFFh6m9RAx5nvEhZLIRAoAbAKCIv7Q/+h+xuVKH1MKxOLZ2pAscLACeKj7e
CKEd18mcM65qcn9p0rgNSKA=
=adVd
-----END PGP SIGNATURE-----