[Zope-CMF] Missing Event Handler for CMFCatalogAware

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Charlie Clark wrote:
> Am 12.11.2008 um 11:53 schrieb yuppie:
> 
>> This is the checkin that added CMFCatalogAware to PortalFolder:
>> http://svn.zope.org/?rev=35114&view=rev
> 
> Wow, that's some time ago.
> 
>> It explains why and how it was done. Maybe a first step to clean  
>> this up would be to split CMFCatalogAware into separate mixins.

Or take the responsibility out of the class altogether via event
subscriptions.

> I'm probably missing something but nothing related to IDiscussable  
> seems to be in either PortalFolder or CMFCatalogAware or is that the  
> OpaqueItem stuff?

Yes:  getting the 'talkback' object's items (the comments) catalogued
was the point of the checkin.

> You're probably right to suggest that this should be a two-step  
> change: clean-up CMFCatalogAware; remove it from PortalFolder (it can  
> stay in SkinnedFolder).

If we made the bit about finding the opaque subitems part of the event
subscriber, then we could remove the base class from PortalFolder directly.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJGtWn+gerLs4ltQ4RAgmxAJ9Oe57ZkVkRueZ4cU42Ku39Pzw0BACfRSwC
XjlE1vpczfaMzGlbj1Gsi28=
=MmON
-----END PGP SIGNATURE-----