[Zope-CMF] SVN: Products.GenericSetup/trunk/Products/GenericSetup/ Don't bomb out with an AttributeError when encoding an attribute

[Maurits van Rees]

yuppie, on 2010-03-03:
>>> On 3/3/10 11:48 , Maurits van Rees wrote:
>>>> Log message for revision 109595:
>>>>     Don't bomb out with an AttributeError when encoding an attribute
>>>>     with value None that is being exported; just use an empty string then.
>>>>     Case in point: create a Plone Site, set the MailHost settings through
>>>>     the Site Setup; an export of the mailhost settings would then fail if
>>>>     some of the values (e.g. smtp_uid) were blank (None).
>>>
(...)
> I think the fix is in the wrong place. I doubt None is a valid value for 
> a DOM attribute. So instead of working around invalid data we should 
> make sure only valid data is written to the DOM.
>
> AFAICS MailHostXMLAdapter._exportNode is the right place to fix this.

Makes sense.  Done in r109614.

-- 
Maurits van Rees | http://maurits.vanrees.org/
            Work | http://zestsoftware.nl/
What are you going to create today?