[Zope-CMF] GenericSetup creates exports with bad directory permissions

[Maurits van Rees]

yuppie, on 2010-03-03:
> Hi Maurits!
>
>
> Maurits van Rees wrote:
>> Using a checkout of CMF.buildout/branches/zope212-cmf22 (or Plone
>> 4.0a5 or latest from plone-coredev) I see that portal_setup generates
>> tarball exports where the permissions on directories are wrong: the
>> executable bit has not been set, so you cannot cd into that
>> directory.
>>
>> This is with python 2.6, so there might have been changes to the
>> tarfile module that cause this.
>>
>> yuppie, you did some changes in Products/GenericSetup/context.py on 13
>> December that might be related.  Does this behaviour ring a bell for
>> you?  Aha, if I revert to revision 106439, right before your changes,
>> the export goes fine, at least on my machine (Ubuntu Linux 9.04).
>>
>> I can always open a bug report, but sometimes a mailing list works
>> faster.  At least it prompted me to try and revert some recent changes
>> to see if that helped.  :-)  https://bugs.launchpad.net/zope-cmf would
>> be the correct place for that, right?
>
> Yes. But if you fix it yourself you don't need to report it on launchpad ;)

Exactly. :)

> Looks like r106440 contains a bug. The default value of TarInfo.mode is 
> not suitable here. I guess this can easily be fixed by setting a 
> different 'info.mode' for directories.

Right, by default this gets mode 420 and it should be 493.

>>> oct(420)
'0644'
>>> tarfile.filemode(493)
'-rwxr-xr-x'
>>> oct(493)
'0755'
>>> tarfile.filemode(420)
'-rw-r--r--'

Fixed on trunk in r109626.

-- 
Maurits van Rees | http://maurits.vanrees.org/
            Work | http://zestsoftware.nl/
What are you going to create today?