[Zope-CMF] SVN: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py remove type check that seem useless

Godefroid Chapelle gotcha at bubblenet.be
Thu Jan 13 06:04:32 EST 2011


Hi,

I have fixed an exportimport bug on branch 2.2 : see tests in revision 
119560.

I'd like some review before merging the fix into trunk.

I do not know for sure that I can remove the type check.

Thanks

Gotcha

Le 13/01/11 12:00, Godefroid Chapelle a écrit :
> Log message for revision 119561:
>    remove type check that seem useless
>
> Changed:
>    U   Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py
>
> -=-
> Modified: Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py
> ===================================================================
> --- Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py	2011-01-13 10:44:41 UTC (rev 119560)
> +++ Products.CMFCore/branches/2.2/Products/CMFCore/exportimport/content.py	2011-01-13 11:00:16 UTC (rev 119561)
> @@ -101,15 +101,9 @@
>           parser = ConfigParser()
>
>           title = self.context.Title()
> -        if isinstance(title, unicode):
> -            title_str = title.encode(self._encoding)
> -        else:
> -            title_str = title
> +        title_str = title.encode(self._encoding)
>           description = self.context.Description()
> -        if isinstance(description, unicode):
> -            description_str = description.encode(self._encoding)
> -        else:
> -            description_str = description
> +        description_str = description.encode(self._encoding)
>           parser.set('DEFAULT', 'Title', title_str)
>           parser.set('DEFAULT', 'Description', description_str)


-- 
Godefroid Chapelle (aka __gotcha) http://bubblenet.be



More information about the Zope-CMF mailing list