[Zope-CMF] SVN: Products.CMFDefault/trunk/ Add dependency on zope.app.locales.

[Maurits van Rees]

Op 28-08-12 10:28, yuppie schreef:
> Hi!
>
>
> Maurits van Rees wrote:
>> Log message for revision 127521:
>>    Add dependency on zope.app.locales.
> [...]
>> Modified: Products.CMFDefault/trunk/setup.py
>> ===================================================================
>> --- Products.CMFDefault/trunk/setup.py    2012-08-18 16:05:00 UTC (rev
>> 127520)
>> +++ Products.CMFDefault/trunk/setup.py    2012-08-18 16:09:30 UTC (rev
>> 127521)
>> @@ -52,6 +52,7 @@
>>             'Products.MailHost',
>>             'Products.PythonScripts',
>>             'zope.formlib',
>> +          'zope.app.locales',
>>             ],
>>         tests_require=[
>>             'zope.testing >= 3.7.0',
>>
>
> Is it really necessary to declare that dependency? AFAICS CMFDefault
> depends on zope.app.locales[extract], but only if used with
> z3c.recipe.i18n for extracting i18n messages. In production we don't
> need zope.app.locales and its dependencies.
>
> Maybe this could/should be declared in an extra if you want to be explicit?

Ah, good point.  I added several dependencies to several packages at 
this point, when I had trouble getting a development version of Plone to 
start due to some undeclared dependencies.

In this case CMFDefault imports zope.app.locales, but this is done in 
code that is normally not loaded.  I have now moved z.a.locales to a new 
'extract' extras_dependencies.

Thanks,

-- 
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl