[Zope-CMF] Products.CMFCore release

[Jens Vagelpohl]

On Oct 11, 2013, at 19:11 , Tres Seaver <tseaver at palladion.com> wrote:

> Signed PGP part
> On 10/11/2013 07:34 AM, Harald Friessnegger wrote:
> > hi tres
> > 
> > sorry for the last mail. it got sent accidentally before i could
> > finish it.
> > 
> > i did a minor change to cmfcore that i'd love to see in the next
> > releases of plone. http://dev.plone.org/ticket/10071#comment:8
> > 
> > could you please review the change and do a new release on pypi?
> > 
> > thanks for your reply and have a nice weekend
> 
> I can't get to this before sometime next week.  Hanno and Jens are the
> other two release-makers (CC'ed).

If it was just about making a release I could have done it quickly. However, I see two issues I don't have time to look into right now:

- the change has no unit test

- two others are failing:

<snip>

Failure in test test_getActionObject_oldskool_action_deprecated (Products.CMFCore.tests.test_ActionsTool.ActionsToolTests)
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/local/src/Products.CMFCore-2.2/Products/CMFCore/tests/test_ActionsTool.py", line 94, in test_getActionObject_oldskool_action_deprecated
    '2.4. Use Action and Action Category objects instead.' in warning)
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 424, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true



Failure in test test_getDiff (Products.CMFCore.tests.test_FSPythonScript.CustomizedPythonScriptTests)
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/local/src/Products.CMFCore-2.2/Products/CMFCore/tests/test_FSPythonScript.py", line 274, in test_getDiff
    self.assertEqual(list(cps.getDiff()), _DIFF_TEXT.splitlines())
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 515, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 744, in assertListEqual
    self.assertSequenceEqual(list1, list2, msg, seq_type=list)
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 726, in assertSequenceEqual
    self.fail(msg)
  File "/usr/local/Cellar/python/2.7.5/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 412, in fail
    raise self.failureException(msg)
AssertionError: Lists differ: ['--- original', '+++ modified... != ['--- original ', '+++ modifie...

First differing element 0:
--- original
--- original 

- ['--- original',
+ ['--- original ',
?               +

-  '+++ modified',
+  '+++ modified ',
?               +

   '@@ -7,4 +7,4 @@',
   ' ##parameters=',
   ' ##title=',
   ' ##',
   "-return 'cps'",
   "+return 'cps -- replaced'"]

  Ran 235 tests with 2 failures and 0 errors in 0.541 seconds.
Tearing down left over layers:
  Tear down zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
Total: 612 tests, 2 failures, 0 errors in 8.445 seconds.

jens


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.zope.org/pipermail/zope-cmf/attachments/20131013/3eb83c69/attachment.sig>