[Zope-Coders] Re: ZPT breakage (was Zope test results )

[Tres Seaver]

Tres Seaver wrote:

> WAAAA!  This patch, checked in this morning with the note
> "Merge fix from 2.5 branch", causes the breakage::
> 
> --- Products/PageTemplates/TALES.py    2001/11/28 15:51:01    1.24
> +++ Products/PageTemplates/TALES.py    2001/12/10 15:44:12    1.25
> @@ -109,7 +109,7 @@
>      def next(self):
>          try:
>              if ZTUtils.Iterator.next(self):
> -                self._context.setLocal(self.name, self.seq[self.index])
> +                self._context.setLocal(self.name, self.item)
>                  return 1
>          except TALESError:
>              raise
> 
> (or see
> <http://cvs.zope.org/Products/PageTemplates/TALES.py.diff?r1=1.24&r2=1.25&sortby=date>) 
> 
> 
> Only thing is, there is no branched revision! (1.24 *is* the 2.5 branch)

It looks like the patched line should be::


 > +                self._context.setLocal(self.name, self.item())

With that change, the unittests pass again on the head.

Evan, can you confirm?

Tres.
-- 
===============================================================
Tres Seaver                                tseaver@zope.com
Zope Corporation      "Zope Dealers"       http://www.zope.com