[Zope-Coders] CallProfiler and Refresh.

[Brian Lloyd]

> > What's the next step? Can someone check out the 
> anthony-CallProfiler-branch
> > and let me know of any issues before it is ready to be merged?
> 
> I've heard nothing on this - is it safe to assume no answer == 
> "go ahead, check it into the trunk"? 
> 
> (and the next question of course is, what happens if I get no answer to
> _this_ message :)

I've spent some time working with it today, and have a few 
comments.

  - It seems like the ability to turn profiling on and off should 
    be protected by a more specific permission than "View management 
    screens", considering that you can affect the overall performance 
    of the site. What do you think of some sort of "Use call profiler" 
    permission so that this is explicit?

  - The add form for CallProfiler objects is nearly blank other 
    than the id text box and an oddly-named "Submit Query" button. 
    This should be fixed to be consistent with other managment 
    "add" screens (some short verbage, help link, consistent look 
    etc.)

  - There's no help / docs that I could find other than the README
    in the CallProfiler product directory. There needs to be at 
    least basic help for each of the views and some fodder for 
    the online Zope book before it can be merged / go into a 
    release. (Note that it's usually OK for the Zope book fodder 
    to be a mildly reworked and shined up version of the help 
    material).

  - The different views aren't too consistent style-wise. We should 
    get them using the standard ZMI styles. That's a bit of arcana, 
    I know, as it's underdocumented what "should" be done. I'd be 
    happy to help out with that part if you'd like.

  - I'd _really_ like to find an answer to the refresh problem 
    if possible wrt: publisher hooks. The idea that a refresh 
    could hose the whole instance makes me feel oogy :) I can 
    pitch in on this as well if it will help.

Overall though, it's getting close. I like the way you've 
factored the monkey-patcher. I suspect that making that 
approach work for the cache / publisher patching could 
be a way to make refresh work without problems too.



Brian Lloyd        brian@zope.com
V.P. Engineering   540.361.1716       
Zope Corporation   http://www.zope.com