[Zope-Coders] [fdrake@gmail.com: [Zope-Checkins] SVN: zdaemon/trunk/zdctl.py try to fix borked umask handling]

[Sidnei da Silva]

On Thu, Jun 09, 2005 at 12:20:39AM -0400, Fred Drake wrote:
| Yes, but... did you *test* it?  Perhaps you missed the email where I
| specifically asked that you check it out.  The existing test suite
| clearly didn't cover it, or you wouldn't have found a bug there to
| begin with, and I just don't have time for dealing with zdaemon much
| right now.

It doesn't prevent zope from starting at least, so your fix fixes
that. Haven't tested if it fixes the bug that the previous fix
intended to fix and ended up breaking zope's startup *wink*.

>From reading the patch it looks very sane, except maybe for the second
part of it where you put os.umask() inside the if. Shouldn't that one
be outside the if?

fixated-fix-a-holic-fix-o-happily-your's

-- 
Sidnei da Silva <sidnei at awkly.org>
http://awkly.org - dreamcatching :: making your dreams come true
http://www.enfoldsystems.com
http://plone.org/about/team#dreamcatcher

<hypatia> I'm not part of the American way because they don't let you own those kind of weapons around here :)