[ZCM] [ZC] 1463/ 5 Comment "FSDump mishandles FSZSQL Method dump"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #1463 Update (Comment) "FSDump mishandles FSZSQL Method dump"
 Status Accepted, Zope/bug medium
To followup, visit:
  http://zope.org/Collectors/Zope/1463

==============================================================
= Comment - Entry #5 by elzubeir on Aug 13, 2004 3:51 am


Uploaded:  "final-dumper-patch"
 - http://zope.org/Collectors/Zope/1463/final-dumper-patch/view
Okay, I think this should deal with the different types of newlines.

________________________________________
= Accept - Entry #4 by tseaver on Aug 12, 2004 7:31 pm

 Status: Pending => Accepted

 Supporters added: tseaver

Thanks, I will look for the updated patch.
________________________________________
= Comment - Entry #3 by elzubeir on Aug 12, 2004 6:26 pm

One more thing I noticed about this. The arguments (obj.arguments_src) dumps it with \r\n so that won't show unless they are replaced with whitespace.

Doing a simple obj.arguments_src.replace('\r\n', ' ') did the trick for me, but I'm not sure how other browsers deal with newlines (firefox here).

Will do a little more investigation and update patch accordingly.
________________________________________
= Comment - Entry #2 by elzubeir on Aug 12, 2004 5:32 pm


Uploaded:  "Dumper.patch.gz"
 - http://zope.org/Collectors/Zope/1463/Dumper.patch.gz/view
Oops.. looks like I forgot to remove the _'s from some of the lines. Here is the 'right' patch.
________________________________________
= Request - Entry #1 by elzubeir on Aug 12, 2004 2:37 pm


Uploaded:  "Dumper.py.patch.gz"
 - http://zope.org/Collectors/Zope/1463/Dumper.py.patch.gz/view
FSDump incorrectly dumps ZSQL methods.

1. The extension is wrong (should be .zsql)
2. There are no .metadata files for zsql methods, they are kept in the same file under a dtml-comment.

The attached patch should solve this problem.
==============================================================