[ZCM] [ZC] 1168/ 3 Comment "Import error in lib/python/AccessControl/ZopeSecurityPolicy.py"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #1168 Update (Comment) "Import error in lib/python/AccessControl/ZopeSecurityPolicy.py"
 Status Accepted, Zope/bug+solution critical
To followup, visit:
  http://zope.org/Collectors/Zope/1168

==============================================================
= Comment - Entry #3 by tseaver on Jan 9, 2004 12:54 pm

> = Accept - Entry #2 by tseaver on Jan 9, 2004 12:35 pm
> 
>  Status: Pending => Accepted
> 
>  Supporters added: tseaver
> 
> > = Request - Entry #1 by nuxeo on Jan 9, 2004 12:00 pm
> > 
> > File
> >   /home/fermigier/zopes/Zope-2.6.3-linux2-x86/lib/python/AccessControl/ZopeSecurityPolicy.py", line 143, in validate
> >     if (isinstance(name, StringType) or
> > NameError: global name 'UnicodeType' is not defined
> > 
> > Fix it by changing line 234:
> > 
> >     from types import StringType
> > 
> > to
> > 
> >     from types import StringType, UnicodeType
> 
> Note that this is actually a backport problem:  Zope 2.6
> doesn't promise to validate Unicode names at all!
> 
> cAccessControl.c has a XXX comment at the equivalent
> line, "What about Unicode".
> 
> I think we should likely just remove the use of
> UnicodeType in the Python version of the ZSP, since it
> is supposed to be the reference implementation for
> the C version;  otherwise, we will need to rev
> cAccessControl.c as well.

My bad here:  the 2.6.3 version of cAccessControl.c
includes the check for Unicode.  Therefore, the original
suggestion is correct.
________________________________________
= Accept - Entry #2 by tseaver on Jan 9, 2004 12:35 pm

 Status: Pending => Accepted

 Supporters added: tseaver

> = Request - Entry #1 by nuxeo on Jan 9, 2004 12:00 pm
> 
> File
>   "/home/fermigier/zopes/Zope-2.6.3-linux2-x86/lib/python/AccessControl/ZopeSecurityPolicy.py", line 143, in validate
>     if (isinstance(name, StringType) or
> NameError: global name 'UnicodeType' is not defined
> 
> Fix it by changing line 234:
> 
>     from types import StringType
> 
> to
> 
>     from types import StringType, UnicodeType

Note that this is actually a backport problem:  Zope 2.6
doesn't promise to validate Unicode names at all!

cAccessControl.c has a XXX comment at the equivalent
line, "What about Unicode".

I think we should likely just remove the use of
UnicodeType in the Python version of the ZSP, since it
is supposed to be the reference implementation for
the C version;  otherwise, we will need to rev
cAccessControl.c as well.
________________________________________
= Request - Entry #1 by nuxeo on Jan 9, 2004 12:00 pm

File "/home/fermigier/zopes/Zope-2.6.3-linux2-x86/lib/python/AccessControl/ZopeSecurityPolicy.py", line 143, in validate
    if (isinstance(name, StringType) or
NameError: global name 'UnicodeType' is not defined

Fix it by changing line 234:

    from types import StringType

to

    from types import StringType, UnicodeType

==============================================================