[ZCM] [ZC] 1117/ 6 Resolve "Packing causes POSKeyError in Zope 2.6.2"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #1117 Update (Resolve) "Packing causes POSKeyError in Zope 2.6.2"
 Status Resolved, Zope/bug critical
To followup, visit:
  http://collector.zope.org/Zope/1117

==============================================================
= Resolve - Entry #6 by tim_one on Jan 19, 2004 3:13 pm

 Status: Accepted => Resolved

Fixes for the original problem have been checked in on the Zope head, 2.6 branch, and 2.7 branch.  This restores the previous behavior of raising FileStorageError if the pack is to a time earlier than a time previously packed to; the data.fs file is not changed then.  A new test was added to ensure this fix doesn't "get lost" again.
________________________________________
= Assign - Entry #5 by tim_one on Jan 16, 2004 11:28 pm

 Status: Pending => Accepted

 Supporters added: jeremy, tim_one

Entries #1 and #2 describe the same problem, and it should be fixed now (in CVS, on the Zope 2.6 branch, the Zope 2.7 branch, and the HEAD).  A pack time earlier than a time previously packed to should indeed raise an exception; the code to do so was mistakenly dropped when part of packing was rewritten to fix other bugs.

Entry #3 doesn't belong in this issue -- this one is about a packing bug.

Not enough in Entry #4 to tell.
________________________________________
= Comment - Entry #4 by ozone on Jan 14, 2004 6:21 am

I'm seeing the same type of corruption on Zope 2.6.2 with FreeBSD 4.8 (using Python 2.1 with WANT_HUGE_STACK_SIZE).
This seems like a very serious bug.

I haven't yet tried updating to Zope 2.6.3.
________________________________________
= Comment - Entry #3 by CMYanko on Jan 8, 2004 8:52 am

I'm getting a POSKeyError in 2.6.1 on a W2K box without having packed at all. I get it trying to view the content of my portal_workflow tool with an error value of '0000000000012423'
________________________________________
= Comment - Entry #2 by sonnq on Nov 14, 2003 10:34 am

This bug is very serious because you can corrupt Data.fs simply by packing it.

In Zope 2.6.1 when I did the same thing (pack(days=0), and then pack(days=1)), Zope raises FileStorageError: "The database has already been packed to a later time or no changes have been made since the last pack".

In Zope 2.6.1 FileStorage.pack() checks if packing is redundant (by calling _redundant_pack) and raises the exception above, while Zope 2.6.2 does not.

________________________________________
= Request - Entry #1 by Anonymous User on Nov 9, 2003 11:39 am

I've got following error with Zope 2.6.2 on both W2K (always) and RH9 (after several tries):
- pack(days=0) -> OK
- pack(days=1) -> data.fs is truncated!
- restart -> POSKeyError
==============================================================