[ZCM] [ZC] 1860/ 3 Resolve "Uses optimistic savepoint in CopySupport._getCopy"

[Collector: Zope Bugs, Features, and Patches ...]

Issue #1860 Update (Resolve) "Uses optimistic savepoint in CopySupport._getCopy"
 Status Resolved, Zope/bug+solution medium
To followup, visit:
  http://www.zope.org/Collectors/Zope/1860

==============================================================
= Resolve - Entry #3 by tim_one on Aug 7, 2005 7:32 pm

 Status: Accepted => Resolved

The changes have been made, on Zope trunk and 2.8 branch, ditto for ZODB 3.4.1b4 and ZODB trunk.
________________________________________
= Assign - Entry #2 by tim_one on Aug 7, 2005 5:17 pm

 Status: Pending => Accepted

 Supporters added: tim_one

Yes, your analysis here makes good sense to me.  I'll make the changes -- thanks!
________________________________________
= Request - Entry #1 by flacoste23 on Aug 4, 2005 7:16 pm


Uploaded:  "Zope-2.8.1-savepoint.patch"
 - http://www.zope.org/Collectors/Zope/1860/Zope-2.8.1-savepoint.patch/view
OFS.CopySupport._getCopy() and ZODB.ImportExport._importFile() (called from _getCopy()) uses
transaction.savepoint(). If the current transaction uses a DataManager which doesn't support savepoint, the copy operation will fail. Since the savepoint feature is used to replace the old commit(1) call and is not meant to be rollback, it would be better to use an optimistic savepoint which won't make the operation fails if a DataManager doesn't support optimistic savepoint.


==============================================================