[ZCM] [ZC] 1675/ 4 Reject "ZCTextIndex throws needless exceptions"

Collector: Zope Bugs, Features, and Patches ... zope-coders-admin at zope.org
Wed May 18 11:33:03 EDT 2005


Issue #1675 Update (Reject) "ZCTextIndex throws needless exceptions"
 Status Rejected, Zope/feature medium
To followup, visit:
  http://www.zope.org/Collectors/Zope/1675

==============================================================
= Reject - Entry #4 by ajung on May 18, 2005 11:33 am

 Status: Pending => Rejected

There is no reason IMO to swallow exception caused by application level input e.g. by non-conforming search queries. Of course you can wrap the ZCatalog calls into a try..except and perform application levels on your own...but this not the task of a low-level component like an index.
________________________________________
= Comment - Entry #3 by chrisw on Jan 21, 2005 4:39 am

See http://collector.zope.org/Zope/1457.

This issue is slightly different in that experience now tells me there should be a knob in ZCTextIndex, probably enabled by default, that said "don't raise exceptions if you can't parse the query"

What it does instead could be either:

- return no results (easy to implement)

- drop the unfinished search term or whatever (better search results for users)
________________________________________
= Comment - Entry #2 by tseaver on Jan 20, 2005 1:11 pm

Chris, you should know better than to post such a vague "issue".
You can't treat the collector as a "note to self" mechanism:  the
rest of us have no idea what exceptions you mean, so we can't even
tell you why they are necessary ;).


________________________________________
= Request - Entry #1 by chrisw on Jan 20, 2005 5:10 am

...there should be a config option to tell it not to.
...and that should probably be set by default.
==============================================================



More information about the Zope-Collector-Monitor mailing list