[Zope-CVS] CVS: Products/ExternalEditor - CHANGES.txt:1.56 zopeedit.py:1.53

[Casey Duncan]

Update of /cvs-repository/Products/ExternalEditor
In directory cvs.zope.org:/tmp/cvs-serv11257

Modified Files:
	CHANGES.txt zopeedit.py 
Log Message:
Move initial check that the editor launched before sending the lock request to zope. This fixes errors that would occur if the editor was closed before the lock request completed.


=== Products/ExternalEditor/CHANGES.txt 1.55 => 1.56 ===
--- Products/ExternalEditor/CHANGES.txt:1.55	Mon Jul 19 11:25:39 2004
+++ Products/ExternalEditor/CHANGES.txt	Mon Jul 19 11:35:13 2004
@@ -2,6 +2,10 @@
 
   Next Release
   
+    - Check if the editor was launched before locking the file in Zope. This
+      prevents errors if the editor is closed before the lock request 
+      completes.
+  
     - Do not ask the user what editor to use on Posix platforms. Instead just
       tell the user to edit the config file. The askstring()
       function does not work with a hidden root Tk window in Python 2.3.4.


=== Products/ExternalEditor/zopeedit.py 1.52 => 1.53 ===
--- Products/ExternalEditor/zopeedit.py:1.52	Mon Jul 19 11:25:39 2004
+++ Products/ExternalEditor/zopeedit.py	Mon Jul 19 11:35:13 2004
@@ -344,11 +344,11 @@
                 command = '%s %s' % (command, self.content_file)
 
             editor = EditorProcess(command)
+            
+        launch_success = editor.isAlive()
         
         if use_locks:
             self.lock()
-            
-        launch_success = editor.isAlive()
 	    
         while 1:
             editor.wait(save_interval or 2)