[Zope-dev] compile warning

[Tres Seaver]

"Dr. Ross Lazarus" <rossl@med.usyd.edu.au>

> I've noticed this flash by before when compiling source distributions
> 
> rossl on innana~/zope216>python wo_pcgi.py > wo_pcgi.log
> ./../Components/zlib/zlib.c: In function `PyZlib_compress':
> ./../Components/zlib/zlib.c:61: warning: assignment from incompatible
> pointer type
> rossl on innana~/zope216>
> 
> fresh zope 2.1.6 source on redhat 6.1/intel.
> AFAIK it's been there for several releases - I'd never thought to ask...
> - in the light of the mysterious core dump/thread problem, does this
> warning matter?

Its a typo, but harmless, since the pointer being cast to the wrong type before
assignment is NULL.  Here's a quick patch if you'd like to squish the warning
(I'll go ahead and check this in on the head of the CVS trunk)::

 diff -u -r1.3 zlib.c
 --- zlib.c      1997/08/07 18:21:15     1.3
 +++ zlib.c      2000/04/17 19:59:19
 @@ -58,7 +58,7 @@
                        "Can't allocate memory to compress data");
        return NULL;
      }
 -  zst.zalloc=(free_func)Z_NULL;
 +  zst.zalloc=(alloc_func)Z_NULL;
    zst.zfree=(free_func)Z_NULL;
    zst.next_out=(Byte *)output;
    zst.next_in =(Byte *)input;

-- 
=========================================================
Tres Seaver  tseaver@digicool.com   tseaver@palladion.com