[Zope-dev] Re: RFC: product initialization cleanup and improvements

[Tres Seaver]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

yuppie wrote:

> Ouch! I thought everything is in place for that feature, but an
> important piece of the puzzle is missing: The fix for checkPermission.
> 
> http://www.zope.org/Collectors/Zope/1774
> 
> _verifyObjectPaste uses a hack to work around that checkPermission
> issue, making 'action' required.
> 
> Tres: You did have a look at issue #1774 a while ago. What do you think:
> How much work would it be to resolve this issue? I'm not a C programmer
> so I can't do it myself...

I have uploaded a patch, with tests, to the collector issue:

  http://www.zope.org/Collectors/Zope/1774/collector_1774.patch/view

I could use another pair of eyeballs on the C part of the code -- the
refcount idioms in that code are pretty nasty, and I finally rewrote
them using 'goto' and Py_XDECREF.  The patch (against the 2.8 branch)
applies cleanly to the 2.9 branch and the trunk, and all tests pass.


Tres.
- --
===================================================================
Tres Seaver          +1 202-558-7113          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDjR2h+gerLs4ltQ4RAuuNAJ9NW7onXtqWahhbpAGg3zsJl3dC/QCghz9c
WfFBTxOeDLDyS/Gp1AN8KxY=
=bz/Y
-----END PGP SIGNATURE-----